Improved redundant-existence-check#1897
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Feb 26, 2026
Merged
Conversation
charlieegan3
approved these changes
Feb 26, 2026
Contributor
|
I guess the look ahead behind could be configurable. |
charlieegan3
removed this pull request from the merge queue due to the queue being cleared
charlieegan3
force-pushed
the
redundant-existence-check-fix
branch
from
254249d to
5f4b36b
Compare
charlieegan3
removed this pull request from the merge queue due to the queue being cleared
By looking in both directions. Still not exhaustive, but that's way too expensive.. and most redundant checks are adjacent to the place of use. Fixes open-policy-agent#1805 Signed-off-by: Anders Eknert <anders.eknert@apple.com>
anderseknert
force-pushed
the
redundant-existence-check-fix
branch
from
5f4b36b to
623f02c
Compare
Member
Author
|
@charlieegan3 yes, but what if you find: foo.bar
super_expensive_call()
foo.bar.baz == 1Is the foo.bar check redundant? Logically yes it is, as the rule will evaluate the same without it. But it’s also a reasonable way to guard the more expensive computation below, making it not redundant. Like a poor man’s indexer. That’s why being exhaustive here is next to impossible 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By looking in both directions. Still not exhaustive, but that's way too expensive.. and most redundant checks are adjacent to the place of use.
Fixes #1805